Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: not to display obsoleted snapshots when test with -t #8122

Merged
merged 2 commits into from
Oct 16, 2024
Merged

test: not to display obsoleted snapshots when test with -t #8122

merged 2 commits into from
Oct 16, 2024

Conversation

LingyuCoder
Copy link
Collaborator

@LingyuCoder LingyuCoder commented Oct 15, 2024 •
edited
Loading

Summary

There is no need to output all the obsoleted snapshots when test with -t which filters the test cases.

Before:

image

After:
image

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Oct 15, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 15, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 6eb2f77
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/670e2f303c55100008d941a9

@LingyuCoder LingyuCoder changed the title test: not display obsoleted snapshots when test with -t test: not to display obsoleted snapshots when test with -t Oct 16, 2024
chenjiahan
chenjiahan approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LingyuCoder LingyuCoder merged commit 5fe525b into main Oct 16, 2024
38 checks passed
@LingyuCoder LingyuCoder deleted the test/ignore-obsoleted-snaoshots branch October 16, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz jerrykingxyz is a code owner

Assignees

@LingyuCoder LingyuCoder

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LingyuCoder @chenjiahan